lkml.org 
[lkml]   [2014]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] checkpatch: Emit a warning on file add/move/delete
    From
    Date
    On Fri, 2014-07-04 at 16:11 +0100, Andy Whitcroft wrote:
    > On Thu, Jul 03, 2014 at 05:46:56PM -0700, Joe Perches wrote:
    > > Whenever files are added, moved, or deleted, the
    > > MAINTAINERS file patterns can be out of sync or
    > > outdated.
    > >
    > > To try to keep MAINTAINERS more up-to-date, add a
    > > one-time warning whenever a patch does any of those.
    []
    > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
    []
    > > +# Check for added, moved or deleted files
    > > + if (!$reported_maintainer_file && !$in_commit_log &&
    > > + ($line =~ /^(?:new|deleted) file mode\s*\d+\s*$/ ||
    > > + $line =~ /^rename (?:from|to) [\w\/\.\-]+\s*$/ ||
    > > + ($line =~ /\{\s*([\w\/\.\-]*)\s*\=\>\s*([\w\/\.\-]*)\s*\}/ &&
    > > + (defined($1) || defined($2))))) {
    > > + $reported_maintainer_file = 1;
    > > + WARN("FILE_PATH_CHANGES",
    > > + "added, moved or deleted file(s), does MAINTAINERS need updating?\n" . $herecurr);
    > > + }
    > > +
    []
    > That seems like a sensible plan. Sometime we might try and work out if
    > any entries are affected or needed.
    >
    > I think you are checking against the git ways of mentioning this only,

    Yes, I believe so.

    > don't know if there is any milage in checking the dates which also
    > convey add/remove info via datea at the epoch.

    I don't remember what that date format looks like.
    Got an example?

    Maybe there's value in checking the diff file header
    for /dev/null

    Something like:

    --- t.c 2014-04-11 10:57:07.767131132 -0700
    +++ /dev/null 2014-06-30 13:19:01.524210166 -0700

    or

    --- /dev/null 2014-06-30 13:19:01.524210166 -0700
    +++ t.c 2014-04-11 10:57:07.767131132 -0700

    Is there some other form?



    \
     
     \ /
      Last update: 2014-07-04 19:41    [W:5.303 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site