Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] arm: get rid of hardcoded assumptions about kernel stack size | Date | Fri, 04 Jul 2014 12:27:04 +0200 |
| |
On Friday 04 July 2014 11:13:31 Andrey Ryabinin wrote: > > > > but I wonder if there is a way to avoid the extra include here, as it might also > > cause a general slowdown because of asm/memory.h getting pulled into more .c > > files. Would it be reasonable to hardcode PAGE_SIZE here? > > > > IMO it's a bug of iop13xx platform, that it includes "higlevel" linux/reboot.h > from a very "lowlevel" header mach/iop13xx.h. I think it should be fixed with a patch above. > Slowing down of kernel build for a few more seconds is not good enough reason for me to > hardcode PAGE_SIZE here.
I don't think we can pinpoint a specific header that is "wrong" here, the fundamental problem is that our header files are a bit messy when it comes to recursive inclusion and we'd be better off if we generally were a little more careful about including headers from other headers.
It's also very hard to retroactively clean this up on a large scale.
Arnd
| |