lkml.org 
[lkml]   [2014]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 00/18] staging: comedi: amplc_pci224: remove legacy stuff
Date
On Thursday, July 31, 2014 6:48 AM, Ian Abbott wrote:
> The "amplc_pci224" driver retains a "legacy" attach mechanism via the
> `COMEDI_DEVCONFIG` ioctl and the comedi driver "attach" hook, but
> usually attaches PCI devices automatically via the comedi driver's
> "auto_attach" hook. The legacy mechanism is only retained so that
> options can be passed via the ioctl to indicate how some hardware
> jumpers are set on the boards, which is used to set up the range tables.
> That's no use if the PCI device is attached automatically as the range
> tables will be set up according to the factory default jumper positions.
>
> Change the range tables to include all possible ranges, regardless of
> jumper positions. Then there is no need to have options to control
> setting up the range tables and the "legacy" attach mechanism can be
> removed.
>
> Also, tidy the code up a bit.

Looks good.

Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>

Side note:

Now that the manual attach has been removed, you could also remove
the board information from the comedi_driver declaration.

Regards,
Hartley



\
 
 \ /
  Last update: 2014-07-31 23:01    [W:0.138 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site