lkml.org 
[lkml]   [2014]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 3/4] ARM: dts: Clean up exynos5250-snow
Andreas,

Please see my comments inline.

On 31.07.2014 18:08, Andreas Färber wrote:
> Use the new style of referencing inherited nodes and use symbolic names.
>
> Suggested-by: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Andreas Färber <afaerber@suse.de>

[snip]

> -
> usb@12110000 {
> - samsung,vbus-gpio = <&gpx1 1 0>;
> + samsung,vbus-gpio = <&gpx1 1 GPIO_ACTIVE_HIGH>;
> };

This is a higher level node being overridden, so it should be specified
using references too.

>
> fixed-rate-clocks {
> @@ -287,7 +206,7 @@
> };
>
> hdmi {

Ditto.

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-07-31 22:01    [W:0.034 / U:0.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site