lkml.org 
[lkml]   [2014]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] staging: comedi: ii_pci20kc: request and ioremap memory
Date
On Thursday, July 31, 2014 7:57 AM, Ian Abbott wrote:
> The "ii_pci20kc" module is a comedi driver for Intelligent Instruments
> PCI-20001C carrier board and modules. Despite the name, this is
> actually an ISA board and uses 1K of ISA memory space (below 1M) for the
> main board plus up to three modules. The address is set by hardware
> jumpers.
>
> When the board is attached to Comedi via the `COMEDI_DEVCONFIG` ioctl
> and the driver's legacy "attach" handler, the base address is passed in.
> The driver currently uses that address as-is, which is a bad idea. It
> doesn't even reserve the memory region.
>
> Fix that by sanity checking the passed in address, reserving the memory
> region and ioremapping it.
>
> Replace the current "detach" handler `comedi_legacy_detach()` with a new
> handler `ii20k_detach()` which unmaps the memory and releases the
> region.
>
> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
> ---
> drivers/staging/comedi/drivers/ii_pci20kc.c | 32 ++++++++++++++++++++++++++---
> 1 file changed, 29 insertions(+), 3 deletions(-)

Thanks for fixing this!

Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>



\
 
 \ /
  Last update: 2014-07-31 20:01    [W:0.036 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site