lkml.org 
[lkml]   [2014]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCHv9 2/4] mailbox: Introduce framework for mailbox
From
On 23 July 2014 20:56, Lee Jones <lee.jones@linaro.org> wrote:
> On Wed, 23 Jul 2014, Jassi Brar wrote:

>> >> + if (chan->txdone_method == (TXDONE_BY_POLL | TXDONE_BY_ACK))
>> >> + chan->txdone_method = TXDONE_BY_POLL;
>> >
>> > Unless you're leaving it there for clarity, you can drop the
>> > "TXDONE_BY_POLL |" from if().
>> >
>> We need to check for both.
>
> What I'm trying to get at is; if it's already TXDONE_BY_POLL, there is no
> need to set it to TXDONE_BY_POLL.
>
In mbox_request_channel() we added the ACK flag, if POLL was set and
now we need to revert that in mbox_free_channel().


Thanks
Jassi


\
 
 \ /
  Last update: 2014-07-31 19:41    [W:0.055 / U:1.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site