Messages in this thread | | | Date | Thu, 31 Jul 2014 08:52:11 +0200 | From | Jean Delvare <> | Subject | Re: [PATCH 0/3] therm_windtunnel doesn't work properly on PowerMac G4 |
| |
Hi Ben, Goffredo,
On Thu, 31 Jul 2014 11:27:00 +1000, Benjamin Herrenschmidt wrote: > On Wed, 2014-07-30 at 22:50 +0200, Goffredo Baroncelli wrote: > > I am writing to you Jean and Benjamin because it seem that both > > worked on these items. > > > > On a PowerMac G4 I noticed that between the kernel v3.2 and v3.14 I lost > > the fan management. > > > > I found on internet other references to this kind of problem [2]
Yay! Thanks a lot Goffredo! I've been waiting for this driver to be finally converter to the standard device driver model for years, literally. I'm very happy to finally see this happen :-)
The i2c_driver.attach_adapter method was marked for removal in September 2011 so we are almost 3 year late on the schedule :-(
> Patches look good, thanks. Jean do you want to apply them or should I ?
Please pick them, they are totally macintosh-specific so they won't interact with anything I have in my tree. Plus I can't even built-test them.
This leaves only two drivers still using the old binding model: macintosh/therm_pm72 and sound/ppc/keywest. Could any of you please convert these to the standard binding model so that I can finally get rid of i2c_driver.attach_adapter? That would be wonderful.
Thanks again, -- Jean Delvare SUSE L3 Support
| |