lkml.org 
[lkml]   [2014]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: DNAME_INLINE_LEN versus CONFIG_GENERIC_LOCKBREAK
Date
Rasmus Villemoes <linux@rasmusvillemoes.dk> writes:

> In dcache.h, DNAME_INLINE_LEN is carefully chosen so that sizeof(struct
> dentry) is a (specific) multiple of 64 bytes. Obviously this breaks when
> certain debug options are chosen (DEBUG_LOCK_ALLOC and DEBUG_SPINLOCK),
> but also, AFAICT, on architectures with CONFIG_GENERIC_LOCKBREAK.
>
> I'm not sure it matters, but if it does, I'd suggest putting a
> BUILD_BUG_ON somewhere, protected by suitable #ifdefs, so that the code
> documents the assumptions that went into the particular choice of
> DNAME_INLINE_LEN (this would also help catch changes to some of the
> structures embedded in struct dentry which would violate those
> assumptions).

The right fix would be to pad it correctly for these other variants
too.

Checking for magic numbers would be nasty though.

-Andi

--
ak@linux.intel.com -- Speaking for myself only


\
 
 \ /
  Last update: 2014-07-03 22:21    [W:0.270 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site