lkml.org 
[lkml]   [2014]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/2 v6] HID: gt683r: fix race condition
    On Thu, Jul 3, 2014 at 10:34 AM, Johan Hovold <johan@kernel.org> wrote:
    > On Thu, Jul 03, 2014 at 08:17:08PM +0300, Janne Kanniainen wrote:
    >> This will fix race condition noticed by Oliver Neukum. Sysfs files are
    >> created before mutex and work are initialized.
    >>
    >> Signed-off-by: Janne Kanniainen <janne.kanniainen@gmail.com>
    >
    > Reviewed-by: Johan Hovold <johan@kernel.org>
    >

    Good, merged to my tree.
    -Bryan

    >> ---
    >> drivers/hid/hid-gt683r.c | 6 +++---
    >> 1 file changed, 3 insertions(+), 3 deletions(-)
    >>
    >> diff --git a/drivers/hid/hid-gt683r.c b/drivers/hid/hid-gt683r.c
    >> index 077f7a1..073bd80 100644
    >> --- a/drivers/hid/hid-gt683r.c
    >> +++ b/drivers/hid/hid-gt683r.c
    >> @@ -227,6 +227,9 @@ static int gt683r_led_probe(struct hid_device *hdev,
    >> if (!led)
    >> return -ENOMEM;
    >>
    >> + mutex_init(&led->lock);
    >> + INIT_WORK(&led->work, gt683r_led_work);
    >> +
    >> led->mode = GT683R_LED_NORMAL;
    >> led->hdev = hdev;
    >> hid_set_drvdata(hdev, led);
    >> @@ -271,9 +274,6 @@ static int gt683r_led_probe(struct hid_device *hdev,
    >> goto fail;
    >> }
    >>
    >> - mutex_init(&led->lock);
    >> - INIT_WORK(&led->work, gt683r_led_work);
    >> -
    >> return 0;
    >>
    >> fail:


    \
     
     \ /
      Last update: 2014-07-03 21:01    [W:3.863 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site