lkml.org 
[lkml]   [2014]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86, efi: print debug values in Kib not MB
From
Date
On Tue, 2014-07-29 at 15:42 -0700, David Rientjes wrote:
> On Wed, 30 Jul 2014, Borislav Petkov wrote:
>
> > On Tue, Jul 29, 2014 at 06:32:56PM -0400, Prarit Bhargava wrote:
> > > and it was best to keep the code simple with a KiB.
> >
> > You're missing the point - the output doesn't get simple with KiB. Read
> > the example I just gave you!
> >
> > (13893632kiB) is actively *not* helping when one looks at it!
> >
>
> /proc/meminfo must be frustrating then, too.
>
> If Prarit is going to implement this suggested reverse memparse() then it
> would be nice to also have it as a generic function that others can use.

Maybe yet another vsprintf extension?

Maybe %pH<vartype> where vartype is one of [hh, h, u, ul, ull]
with something like
u64 t1 = (u64)*(appropriate cast)vartype;
u64 t2 = t1;
int index = 0;
while ((t1 >>= 10)) {
index++;
t2 >>= 10;
}

to output the equivalent of
%llu%s, t2, "bkmgtpezy"[index]
ala dump_pagetables




\
 
 \ /
  Last update: 2014-07-30 02:01    [W:0.055 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site