lkml.org 
[lkml]   [2014]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/2 v4] sched: Rewrite per entity runnable load average tracking
On Tue, Jul 29, 2014 at 09:17:13AM +0800, Yuyang Du wrote:
> On Mon, Jul 28, 2014 at 12:38:12PM +0200, Peter Zijlstra wrote:
> > On Mon, Jul 28, 2014 at 03:02:37AM +0800, Yuyang Du wrote:
> > > > Another thing that might be an issue is that the blocked of a terminated
> > > > task lives on for quite a while until has decayed away.
> > >
> > > Good point. To do so, if I read correctly, we need to hook do_exit(), but probably
> > > we are gonna encounter rq->lock issue.
> > >
> > > What is the opinion/guidance from the maintainers/others?
> >
> > So the entire point of this per entity tracking was to make sure load
> > numbers reflect reality. We account migrations etc., it would be weird
> > to then throw all that out the window and let task exit accumulate crap.
> >
>
> Yes. So I will hook up do_exit.

There is sched_class::task_dead(), pjt wanted to use that for this.

> Hope I did it right. Likewise, also do group entity
> in group destroy and group offline?

group destroy, yes. Offline should mostly fix itself already due to it
actively migrating the actual load around I think.


\
 
 \ /
  Last update: 2014-07-29 15:41    [W:0.055 / U:4.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site