Messages in this thread | | | Date | Sun, 27 Jul 2014 06:19:17 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH] nfs3_list_one_acl(): check get_acl() result with IS_ERR_OR_NULL |
| |
On Sat, Jul 26, 2014 at 02:58:01PM +0300, Andrey Utkin wrote: > There was a check for result being not NULL. But get_acl() may return > NULL, or ERR_PTR, or actual pointer. > The purpose of the function where current change is done is to "list > ACLs only when they are available", so any error condition of get_acl() > mustn't be elevated, and returning 0 there is still valid. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=81111 > Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Looks good, thanks!
Reviewed-by: Christoph Hellwig <hch@lst.de>
should probably get a cc to stable as the original patch has one as well.
| |