Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 1/2] perf tools: Ensure --symfs ends with '/' | Date | Mon, 28 Jul 2014 10:04:07 +0900 |
| |
Hi Arnaldo,
On Fri, 25 Jul 2014 10:15:21 -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Jul 25, 2014 at 10:31:47AM +0900, Namhyung Kim escreveu: >> Minchan reported that perf failed to load vmlinux if --symfs argument >> doesn't end with '/' character. So make sure that the symfs always >> ends with the '/'. > > I don't think this is the right way of doing this, users of > symbol_conf.symfs should instead make sure that they do what they expect > to, i.e. if they want it to be a base directory, make sure that a path > separator is added between it and the relative path following it, if > not, do as they please.
Hmm.. what's the usecase of non-directory symfs? I guess realpath(3) already nullifies such case and defaults to no symfs..
Thanks, Namhyung
| |