Messages in this thread | | | Date | Thu, 24 Jul 2014 10:04:04 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH 04/15] Input: atmel_mxt_ts - implement device tree support |
| |
On 07/24/2014 09:10 AM, Nick Dyer wrote: > On 23/07/14 22:36, Stephen Warren wrote: >> Hmm. It looks like the version of this patch that was actually applied >> varies quite a bit from what was posted, in particular in the >> implementation and call site of mxt_parse_dt(). It'd be nice if the >> commit log had been adjusted to mention this, so it didn't look like *I* >> caused all those compile errors and warnings that the 0-day builder just >> found:-( > > Apologies for my part in this. It doesn't help that this patch went through > several revisions. Is there a best practice for when to remove > signed-off-by or change authorship documented anywhere?
My comment was more directed at the diff between what you posted and what was applied.
I believe the usual practice is:
* If completely re-writing a patch using another as inspiration, change the author and credit them in free-form text, or perhaps with a Based-on-work-by: tag.
* If generally keeping the patch, but just changing a few things, make a note of it in between the s-o-b lines, e.g.:
Signed-off-by: Stephen Warren <swarren@nvidia.com> Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> [assign directly to pdata->t19_keymap to avoid a temporary, description of other changes ...] Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
| |