Messages in this thread | | | Date | Wed, 23 Jul 2014 14:56:47 +0300 | From | Dan Carpenter <> | Subject | Re: [patch] checkpatch: warn on missing spaces in broken up quoted strings |
| |
On Mon, Jun 16, 2014 at 11:27:36AM -0700, Joe Perches wrote: > > > Likely the \\[a-zA-Z] check should include > > > all the tests that the multiple line string exceptions use. > > > > > > (?:\\(?:[ntr]|[0-7]{1,3}|x[0-9a-fA-F]{1,2})|;\s*|\{\s*)"\s*$ > > > > That kind of complicate regex hurts my head. How do I make it not > > complain about: > > "foo\n\t" > > "bar"; > > Did you try it? >
Of course I tried it... I certainly am not able to *read* it. :P I think that I don't know what you meant? Just give me a whole patch I can apply.
I also tested my version against patches and not just whole files and it seems to work fine.
regards, dan carpenter
| |