lkml.org 
[lkml]   [2014]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH v1 12/70] x86, pci, amd_bus: _FROZEN Cleanup
    On Wed, Jul 23, 2014 at 08:07:18PM +0200, Borislav Petkov wrote:
    > Date: Wed, 23 Jul 2014 20:07:18 +0200
    > From: Borislav Petkov <bp@alien8.de>
    > To: "Chen, Gong" <gong.chen@linux.intel.com>
    > Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, tglx@linutronix.de,
    > paulus@samba.org, benh@kernel.crashing.org, tony.luck@intel.com,
    > hpa@zytor.com, jkosina@suse.cz, rafael.j.wysocki@intel.com,
    > linux@arm.linux.org.uk, ralf@linux-mips.org, schwidefsky@de.ibm.com,
    > davem@davemloft.net, viro@zeniv.linux.org.uk, fweisbec@gmail.com,
    > cl@linux.com, akpm@linux-foundation.org, axboe@kernel.dk,
    > JBottomley@parallels.com, neilb@suse.de, christoffer.dall@linaro.org,
    > rostedt@goodmis.org, rric@kernel.org, gregkh@linuxfoundation.org,
    > mhocko@suse.cz, david@fromorbit.com
    > Subject: Re: [RFC PATCH v1 12/70] x86, pci, amd_bus: _FROZEN Cleanup
    > User-Agent: Mutt/1.5.23 (2014-03-12)
    >
    > On Tue, Jul 22, 2014 at 09:58:48PM -0400, Chen, Gong wrote:
    > > Remove XXX_FROZEN state from x86/pci/amd_bus.
    > >
    > > Signed-off-by: Chen, Gong <gong.chen@linux.intel.com>
    > > ---
    > > arch/x86/pci/amd_bus.c | 3 +--
    > > 1 file changed, 1 insertion(+), 2 deletions(-)
    > >
    > > diff --git a/arch/x86/pci/amd_bus.c b/arch/x86/pci/amd_bus.c
    > > index c20d2cc..30f0fca9 100644
    > > --- a/arch/x86/pci/amd_bus.c
    > > +++ b/arch/x86/pci/amd_bus.c
    > > @@ -341,9 +341,8 @@ static int amd_cpu_notify(struct notifier_block *self, unsigned long action,
    > > void *hcpu)
    > > {
    > > int cpu = (long)hcpu;
    > > - switch (action) {
    > > + switch (action & ~CPU_TASKS_FROZEN) {
    > > case CPU_ONLINE:
    > > - case CPU_ONLINE_FROZEN:
    > > smp_call_function_single(cpu, enable_pci_io_ecs, NULL, 0);
    > > break;
    > > default:
    >
    > Or you can kill all the switch-case gunk and make it even more readable:
    >
    But what if new action is added? We have to change it back. If you prefer
    to use that style I can update in next version.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2014-07-24 04:42    [W:3.641 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site