lkml.org 
[lkml]   [2014]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 3.8 076/116] xfs: ioctl check for capabilities in the current user namespace
    From
    Date
    On Wed, 2014-07-23 at 09:12 +1000, Dave Chinner wrote:
    > On Tue, Jul 22, 2014 at 03:21:27PM -0700, Kamal Mostafa wrote:
    > > 3.8.13.27 -stable review patch. If anyone has any objections, please let me know.
    > >
    > > ------------------
    > >
    > > From: Dwight Engen <dwight.engen@oracle.com>
    > >
    > > commit fd5e2aa8653665ae1cc60f7aca1069abdbcad3f6 upstream.
    > >
    > > Use inode_capable() to check if SUID|SGID bits should be cleared to match
    > > [...]
    >
    > Why are you backporting this to 3.8? namespace support didn't come
    > along until much later, so grabbing one patch out of themiddle of a
    > patch series to allow userns support in XFS is likely to cause
    > problems because there's no supporting code in XFS it.
    >
    > Please don't randomly cherry pick userns support patches that change
    > permission checks back into kernels that don't have userns support.

    Yup, that's why we ask for reviews all right! I've dropped these from
    the 3.8-stable queue:

    fs,userns: Change inode_capable to capable_wrt_inode_uidgid
    xfs: ioctl check for capabilities in the current user namespace

    Thanks Dave,

    -Kamal




    \
     
     \ /
      Last update: 2014-07-23 23:41    [W:4.147 / U:1.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site