lkml.org 
[lkml]   [2014]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [RFC PATCH v1 12/70] x86, pci, amd_bus: _FROZEN Cleanup
On Tue, Jul 22, 2014 at 09:58:48PM -0400, Chen, Gong wrote:
> Remove XXX_FROZEN state from x86/pci/amd_bus.
>
> Signed-off-by: Chen, Gong <gong.chen@linux.intel.com>
> ---
> arch/x86/pci/amd_bus.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/x86/pci/amd_bus.c b/arch/x86/pci/amd_bus.c
> index c20d2cc..30f0fca9 100644
> --- a/arch/x86/pci/amd_bus.c
> +++ b/arch/x86/pci/amd_bus.c
> @@ -341,9 +341,8 @@ static int amd_cpu_notify(struct notifier_block *self, unsigned long action,
> void *hcpu)
> {
> int cpu = (long)hcpu;
> - switch (action) {
> + switch (action & ~CPU_TASKS_FROZEN) {
> case CPU_ONLINE:
> - case CPU_ONLINE_FROZEN:
> smp_call_function_single(cpu, enable_pci_io_ecs, NULL, 0);
> break;
> default:

Or you can kill all the switch-case gunk and make it even more readable:

Index: b/arch/x86/pci/amd_bus.c
===================================================================
--- a/arch/x86/pci/amd_bus.c 2014-07-23 20:04:44.074436425 +0200
+++ b/arch/x86/pci/amd_bus.c 2014-07-23 20:05:14.282436087 +0200
@@ -340,15 +340,9 @@ static void enable_pci_io_ecs(void *unus
static int amd_cpu_notify(struct notifier_block *self, unsigned long action,
void *hcpu)
{
- int cpu = (long)hcpu;
- switch (action) {
- case CPU_ONLINE:
- case CPU_ONLINE_FROZEN:
- smp_call_function_single(cpu, enable_pci_io_ecs, NULL, 0);
- break;
- default:
- break;
- }
+ if ((action & ~CPU_TASKS_FROZEN) == CPU_ONLINE)
+ smp_call_function_single((long)hcpu, enable_pci_io_ecs, NULL, 0);
+
return NOTIFY_OK;
}

--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--


\
 
 \ /
  Last update: 2014-07-23 21:41    [W:0.025 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site