lkml.org 
[lkml]   [2014]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Random panic in load_balance() with 3.16-rc
    On Wed, Jul 23, 2014 at 10:12:35AM -0700, Linus Torvalds wrote:
    > On Wed, Jul 23, 2014 at 10:03 AM, Peter Zijlstra <peterz@infradead.org> wrote:
    > > On Wed, Jul 23, 2014 at 09:54:23AM -0700, Linus Torvalds wrote:
    > >>
    > >> And I wonder if I have a clue. Look, load_balance_mask is a
    > >> "cpumask_var_t", but I don't see a "alloc_cpumask_var()" for it.
    > >> That's broken with CONFIG_CPUMASK_OFFSTACK.
    > >
    > > kernel/sched/core.c:sched_init()
    > >
    > > plays horrible allocation tricks..
    >
    > No it does not. It allocates a cpumask. Nothing more. If you think it
    > allocates a "cpumask_var()", you are wrong.

    I was merely saying 'something' got allocated, but yes I'll agree its
    not a cpumask_var_t thingy.

    > I agree that the code is an unreadable mess, but that's what
    > "cpumask_size()" is: the minimum required size of the bitmask in a
    > cpumask.

    Latest patch cures at least this part of that mess.


    \
     
     \ /
      Last update: 2014-07-23 21:01    [W:5.843 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site