lkml.org 
[lkml]   [2014]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/9] fs.h: Add argument names to struct file_lock_operations (*funcs)
    On Sun, 20 Jul 2014 11:23:38 -0700
    Joe Perches <joe@perches.com> wrote:

    > Function pointer struct members without argument type names
    > are not very clear. Add them.
    >
    > Signed-off-by: Joe Perches <joe@perches.com>
    > ---
    > include/linux/fs.h | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/include/linux/fs.h b/include/linux/fs.h
    > index 05be298..65685a7 100644
    > --- a/include/linux/fs.h
    > +++ b/include/linux/fs.h
    > @@ -834,8 +834,8 @@ static inline struct file *get_file(struct file *f)
    > typedef void *fl_owner_t;
    >
    > struct file_lock_operations {
    > - void (*fl_copy_lock)(struct file_lock *, struct file_lock *);
    > - void (*fl_release_private)(struct file_lock *);
    > + void (*fl_copy_lock)(struct file_lock *dst, struct file_lock *fl);
    > + void (*fl_release_private)(struct file_lock *fl);
    > };
    >
    > struct lock_manager_operations {

    Seems trivial, but ok...

    Acked-by: Jeff Layton <jlayton@poochiereds.net>


    \
     
     \ /
      Last update: 2014-07-23 20:41    [W:4.136 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site