Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH v2 3/4] virtio: rng: delay hwrng_register() till driver is ready | Date | Wed, 23 Jul 2014 15:21:13 +0930 |
| |
Amit Shah <amit.shah@redhat.com> writes: > On (Mon) 21 Jul 2014 [17:15:51], Amit Shah wrote: >> Instead of calling hwrng_register() in the probe routing, call it in the >> scan routine. This ensures that when hwrng_register() is successful, >> and it requests a few random bytes to seed the kernel's pool at init, >> we're ready to service that request. >> >> This will also enable us to remove the workaround added previously to >> check whether probe was completed, and only then ask for data from the >> host. The revert follows in the next commit. >> >> There's a slight behaviour change here on unsuccessful hwrng_register(). >> Previously, when hwrng_unregister() failed, the probe() routine would > > typo: should be hwrng_register(). > > Please fix this up when picking up the patch.
Done.
All 4 patches applied! Rusty.
| |