lkml.org 
[lkml]   [2014]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] m68k/q40: Revert "m68k/q40: Fix q40_irq_startup() to return -ENXIO on failures"
    On 07/23/2014 05:51 AM, Sasha Levin wrote:
    > Revert since we're trying to return -ENXIO from a function returning
    > unsigned int. Not only it causes compiler warnings it's also obviously
    > incorrect.
    >
    > In general, watch for patches from Nick Krause since they are not even
    > build tested.
    >
    > Signed-off-by: Sasha Levin <sashal@kernel.org>

    Guess I wasn't fast enough with my comments :-(

    Acked-by: Guenter Roeck <linux@roeck-us.net>

    > ---
    > arch/m68k/q40/q40ints.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/arch/m68k/q40/q40ints.c b/arch/m68k/q40/q40ints.c
    > index 9dfa1ea..513f9bb 100644
    > --- a/arch/m68k/q40/q40ints.c
    > +++ b/arch/m68k/q40/q40ints.c
    > @@ -49,7 +49,7 @@ static unsigned int q40_irq_startup(struct irq_data *data)
    > case 1: case 2: case 8: case 9:
    > case 11: case 12: case 13:
    > printk("%s: ISA IRQ %d not implemented by HW\n", __func__, irq);
    > - return -ENXIO;
    > + /* FIXME return -ENXIO; */
    > }
    > return 0;
    > }
    >



    \
     
     \ /
      Last update: 2014-07-23 16:41    [W:2.158 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site