lkml.org 
[lkml]   [2014]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/6] net/macb: add scatter-gather hw feature
Le 21/07/2014 06:13, David Miller a écrit :
> From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> Date: Fri, 18 Jul 2014 16:21:14 +0200
>
>> + if (tx_skb->mapped_as_page) {
>> + dma_unmap_page(&bp->pdev->dev, tx_skb->mapping,
>> + tx_skb->size, DMA_TO_DEVICE);
>> + } else {
>> + dma_unmap_single(&bp->pdev->dev, tx_skb->mapping,
>> + tx_skb->size, DMA_TO_DEVICE);
>> + }
>
> Please do not use curly braces for basic block composed of a single statement.
>
Hi David,

thanks for your review, I'll fix it in the next series of patch.

Regards,

Cyrille
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-07-23 11:21    [W:0.146 / U:1.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site