Messages in this thread | | | Date | Wed, 23 Jul 2014 09:26:30 +0800 | From | Lai Jiangshan <> | Subject | Re: [PATCH] workqueue: get the probable node ID from the first CPU of the mask |
| |
On 07/22/2014 11:30 PM, Tejun Heo wrote: > On Tue, Jul 22, 2014 at 01:04:02PM +0800, Lai Jiangshan wrote: >> + node = cpu_to_node(cpumask_first(pool->attrs->cpumask)); > > Minor but maybe cpumask_any() is a better fit here? >
It is OK, the result are the same. But I still think cpumask_first() is better since its name sounds deterministic while we need a deterministic value for pool->node.
Thanks, Lai
| |