lkml.org 
[lkml]   [2014]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.8 072/116] NFS: populate ->net in mount data when remounting
    Date
    3.8.13.27 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Mateusz Guzik <mguzik@redhat.com>

    commit a914722f333b3359d2f4f12919380a334176bb89 upstream.

    Otherwise the kernel oopses when remounting with IPv6 server because
    net is dereferenced in dev_get_by_name.

    Use net ns of current thread so that dev_get_by_name does not operate on
    foreign ns. Changing the address is prohibited anyway so this should not
    affect anything.

    Signed-off-by: Mateusz Guzik <mguzik@redhat.com>
    Cc: linux-nfs@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    fs/nfs/super.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/fs/nfs/super.c b/fs/nfs/super.c
    index b056b16..f4d000a 100644
    --- a/fs/nfs/super.c
    +++ b/fs/nfs/super.c
    @@ -2167,6 +2167,7 @@ nfs_remount(struct super_block *sb, int *flags, char *raw_data)
    data->timeo = 10U * nfss->client->cl_timeout->to_initval / HZ;
    data->nfs_server.port = nfss->port;
    data->nfs_server.addrlen = nfss->nfs_client->cl_addrlen;
    + data->net = current->nsproxy->net_ns;
    memcpy(&data->nfs_server.address, &nfss->nfs_client->cl_addr,
    data->nfs_server.addrlen);

    --
    1.9.1


    \
     
     \ /
      Last update: 2014-07-23 01:21    [W:4.027 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site