lkml.org 
[lkml]   [2014]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cleanup include/asm-generic/atomic.h
On Tue, 22 Jul 2014, Madhavan Srinivasan wrote:

> On Tuesday 22 July 2014 05:38 AM, David Rientjes wrote:
> > On Tue, 22 Jul 2014, Madhavan Srinivasan wrote:
> >
> >> Commit 4b358e2206 "cleanup include/asm-generic/atomic.h" added
> >> comments for #else/#endif, but ended up adding same comment
> >> "BITS_PER_LONG == 64" on both sides. This patch fixes it.
> >>
> >
> > It's intentionally like that, it comments the condition for which the
> > #endif is matched.
>
> Ok, will change the else comment. And include/asm-generic/local64.h
> also needs a change in comment.
>

The #else comment is fine, it's correct as written. The only use of these
comments is to identify for the reader the #ifdef for which it is matched
when there at least one nested #ifdef.


\
 
 \ /
  Last update: 2014-07-23 01:01    [W:0.114 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site