Messages in this thread | | | Subject | Re: [RFC] 3.16-rc6 -- fs/direct-io.c:1011 from and to uninitialized. | From | Ian Kumlien <> | Date | Tue, 22 Jul 2014 21:23:57 +0200 |
| |
On tis, 2014-07-22 at 12:20 -0700, Randy Dunlap wrote: > On 07/22/2014 12:03 PM, Ian Kumlien wrote: > > This is a resend, try two... > > > > And while the fix is simple, something along the lines of: > > diff --git a/fs/direct-io.c b/fs/direct-io.c > > index 98040ba..64a8286 100644 > > --- a/fs/direct-io.c > > +++ b/fs/direct-io.c > > @@ -910,7 +910,7 @@ static int do_direct_IO(struct dio *dio, struct > > dio_submit *sdi > > > > while (sdio->block_in_file < sdio->final_block_in_request) { > > struct page *page; > > - size_t from, to; > > + size_t from, to = {0}; > > page = dio_get_page(dio, sdio, &from, &to); > > if (IS_ERR(page)) { > > ret = PTR_ERR(page); > > --- > > > > I however don't know if it's in the correct C standard, it compiles fine > > though... (or if this is more gcc speific) > > so... do you know C or not?
I know C but i don't know if this got added in C99 or C11 or how they denote it.
> Why the braces around the 0?
Because it's special
> Why do you initialize 'to' but not 'from'?
The magic of {0} is that it will initialize all your values.
| |