lkml.org 
[lkml]   [2014]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] rbd: Use kmem_cache_free
    From
    On Tue, Jul 22, 2014 at 10:11 PM, Himangi Saraogi <himangi774@gmail.com> wrote:
    > Free memory allocated using kmem_cache_zalloc using kmem_cache_free
    > rather than kfree.
    >
    > The Coccinelle semantic patch that makes this change is as follows:
    >
    > // <smpl>
    > @@
    > expression x,E,c;
    > @@
    >
    > x = \(kmem_cache_alloc\|kmem_cache_zalloc\|kmem_cache_alloc_node\)(c,...)
    > ... when != x = E
    > when != &x
    > ?-kfree(x)
    > +kmem_cache_free(c,x)
    > // </smpl>
    >
    > Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
    > Acked-by: Julia Lawall <julia.lawall@lip6.fr>
    > ---
    > drivers/block/rbd.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
    > index b2c98c1..8381c54 100644
    > --- a/drivers/block/rbd.c
    > +++ b/drivers/block/rbd.c
    > @@ -1158,7 +1158,7 @@ static const char *rbd_segment_name(struct rbd_device *rbd_dev, u64 offset)
    > if (ret < 0 || ret > CEPH_MAX_OID_NAME_LEN) {
    > pr_err("error formatting segment name for #%llu (%d)\n",
    > segment, ret);
    > - kfree(name);
    > + kmem_cache_free(rbd_segment_name_cache, name);
    > name = NULL;
    > }

    We seem to have a helper for this, rbd_segment_name_free(). Care to
    resend?

    Thanks,

    Ilya


    \
     
     \ /
      Last update: 2014-07-22 21:21    [W:4.231 / U:3.436 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site