Messages in this thread | | | Date | Tue, 22 Jul 2014 14:12:39 +0900 | From | Chanwoo Choi <> | Subject | Re: [PATCH] extcon: arizona: Get MICVDD against extcon device |
| |
On 07/18/2014 08:59 PM, Charles Keepax wrote: > Previously we would do a regulator get against the main Arizona device > to obtain the MICVDD regulator. Arizona is an MFD device and normally > MICVDD will be supplied by one of its children (the arizona-micsupp > regulator). As devres destruction for the MFD device will run after all > its children have been destroyed, the regulator will be destroyed before > devres calls regulator_put. This causes a warning from both the > destruction of the child node, as the regulator is still open, and from > the put of the regulator as the regulator device has already been > destroyed. > > A simple fix here is to get the regulator against the extcon device > itself such that devres runs when the child is destroyed. This has the > additional benefit that if for some reason the extcon driver is unloaded > the regulator reference won't hang around until the MFD is unloaded. > > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Applied now, Thanks.
Chanwoo Choi
| |