Messages in this thread | | | Date | Tue, 22 Jul 2014 12:14:41 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range check just before the check for equality |
| |
On Tue, Jul 22, 2014 at 11:52:02AM +0300, Julian Anastasov wrote: > > > - if (copylen > 128) > > > + if (*len < (int) copylen || *len < 0) { > > > + pr_err("get_ctl: len %d < %u\n", *len, copylen); > > > > Don't let users flood dmesg. Just return an error. (This can be > > triggered by non-root as well). > > For now both set and get are privileged operations, > so we can keep it, it can catch if something wrong happens > with the structure sizes.
If you have namespaces enabled then it's not *that* privaleged.
regards, dan carpenter
| |