Messages in this thread | | | Date | Tue, 22 Jul 2014 10:32:24 +0200 | From | Boris BREZILLON <> | Subject | Re: [PATCH 2/2] mtd: nand: add ONFI timing mode to nand_timings converter |
| |
Hi Brian,
On Mon, 21 Jul 2014 19:39:47 -0700 Brian Norris <computersforpeace@gmail.com> wrote:
> On Fri, Jul 11, 2014 at 09:49:42AM +0200, Boris BREZILLON wrote: > > --- /dev/null > > +++ b/drivers/mtd/nand/nand_timings.c > > @@ -0,0 +1,250 @@ > > +/* > > + * Copyright (C) 2014 Free Electrons > > + * > > + * Author: Boris BREZILLON <boris.brezillon@free-electrons.com> > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + * > > + */ > > +#include <linux/mtd/nand.h> > [...] > > +/** > > + * onfi_async_timing_mode_to_sdr_timings - [NAND Interface] Retrieve NAND > > + * timings according to the given ONFI timing mode > > + * @mode: ONFI timing mode > > + */ > > +const struct nand_sdr_timings *onfi_async_timing_mode_to_sdr_timings(int mode) > > +{ > > + if (mode < 0 || mode >= ARRAY_SIZE(onfi_sdr_timings)) > > Might need <linux/kernel.h> for this. > > > + return ERR_PTR(-EINVAL); > > And <linux/err.h> for this. > > > + > > + return &onfi_sdr_timings[mode]; > > +} > > +EXPORT_SYMBOL(onfi_async_timing_mode_to_sdr_timings); > > <linux/export.h> for this.
Thanks for fixing these issues (I tend to rely on other inclusions when the compiler does not yell at me :-))
Best Regards,
Boris
-- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
| |