lkml.org 
[lkml]   [2014]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.8 069/116] Input: elantech - don't set bit 1 of reg_10 when the no_hw_res quirk is set
    Date
    3.8.13.27 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Hans de Goede <hdegoede@redhat.com>

    commit fb4f8f568a9def02240ef9bf7aabd246dc63a081 upstream.

    The touchpad on the GIGABYTE U2442 not only stops communicating when we try
    to set bit 3 (enable real hardware resolution) of reg_10, but on some BIOS
    versions also when we set bit 1 (enable two finger mode auto correct).

    I've asked the original reporter of:
    https://bugzilla.kernel.org/show_bug.cgi?id=61151

    To check that not setting bit 1 does not lead to any adverse effects on his
    model / BIOS revision, and it does not, so this commit fixes the touchpad
    not working on these versions by simply never setting bit 1 for laptop
    models with the no_hw_res quirk.

    Reported-and-tested-by: James Lademann <jwlademann@gmail.com>
    Tested-by: Philipp Wolfer <ph.wolfer@gmail.com>
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/input/mouse/elantech.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
    index dc66ca8..729f75d 100644
    --- a/drivers/input/mouse/elantech.c
    +++ b/drivers/input/mouse/elantech.c
    @@ -819,7 +819,7 @@ static int elantech_set_absolute_mode(struct psmouse *psmouse)
    if (etd->set_hw_resolution)
    etd->reg_10 = 0x0b;
    else
    - etd->reg_10 = 0x03;
    + etd->reg_10 = 0x01;

    if (elantech_write_reg(psmouse, 0x10, etd->reg_10))
    rc = -1;
    @@ -1282,7 +1282,8 @@ static int elantech_reconnect(struct psmouse *psmouse)
    }

    /*
    - * Some hw_version 3 models go into error state when we try to set bit 3 of r10
    + * Some hw_version 3 models go into error state when we try to set
    + * bit 3 and/or bit 1 of r10.
    */
    static const struct dmi_system_id no_hw_res_dmi_table[] = {
    #if defined(CONFIG_DMI) && defined(CONFIG_X86)
    --
    1.9.1


    \
     
     \ /
      Last update: 2014-07-23 08:42    [W:2.509 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site