Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH v7 07/10] x86, mpx: decode MPX instruction to get bound violation information | Date | Sun, 20 Jul 2014 23:07:59 -0700 |
| |
Qiaowei Ren <qiaowei.ren@intel.com> writes: > + */ > +#ifdef CONFIG_X86_64 > + insn->x86_64 = 1; > + insn->addr_bytes = 8; > +#else > + insn->x86_64 = 0; > + insn->addr_bytes = 4; > +#endif
How would that handle compat mode on a 64bit kernel? Should likely look at the code segment instead of ifdef. > + /* Note: the upper 32 bits are ignored in 32-bit mode. */
Again correct for compat mode? I believe the upper bits are undefined.
-Andi -- ak@linux.intel.com -- Speaking for myself only
| |