Messages in this thread | | | From | Peter Feuerer <> | Subject | Re: [PATCH v4 1/6] acerhdf: Adding support for "manual mode" | Date | Sun, 20 Jul 2014 12:42:53 +0200 |
| |
Hi Andreas,
Andreas Mohr writes:
> Hi > > On Sun, Jul 20, 2014 at 02:51:15AM +0200, Peter Feuerer wrote: >> @@ -127,105 +138,107 @@ struct bios_settings_t { >> unsigned char fanreg; >> unsigned char tempreg; >> struct fancmd cmd; >> + int mcmd_enable; >> }; >> >> + >> /* Register addresses and values for different BIOS versions */ >> static const struct bios_settings_t bios_tbl[] = { > > Change-unrelated content here, might want to move away.
You mean this newline?
> Suggestion (if ok from a commit revision/history POV): > git rebase -i s:/'acerhdf: Adding support for "manual mode"'~1 > <"e"dit first commit> > git checkout -p s:/'acerhdf: Adding support for "manual mode"' > <grab hunk [split as needed]> > git commit -m "FIXUP" > git rebase --continue > git rebase -i s:/'acerhdf: Adding support for "manual mode"'~1 > <move FIXUP line post [PATCH v4 6/6] acerhdf: minor clean up> > <do "f"ixup>
If I understand this correctly, you want me to move this new line to patch 6, correct?
> Sorry that I didn't find worse breakage during my review > than this si{mp|ng}le line ;)
No problem, as long as you give your Acked-by / Reviewed-by ;)
--peter;
| |