Messages in this thread | | | Subject | Re: [PATCH v2 1/3] ima: use ahash API for file hash calculation | From | Mimi Zohar <> | Date | Wed, 02 Jul 2014 15:38:00 -0400 |
| |
On Wed, 2014-07-02 at 21:21 +0300, Dmitry Kasatkin wrote: > On 2 July 2014 20:44, Mimi Zohar <zohar@linux.vnet.ibm.com> wrote: > > On Tue, 2014-07-01 at 23:12 +0300, Dmitry Kasatkin wrote: > > > >> -/* > >> - * Calculate the MD5/SHA1 file digest > >> - */ > >> +static struct crypto_ahash *ima_alloc_atfm(enum hash_algo algo) > >> +{ > >> + struct crypto_ahash *tfm = ima_ahash_tfm; > >> + int rc; > >> + > >> + if ((algo != ima_hash_algo && algo < HASH_ALGO__LAST) || !tfm) { > >> + tfm = crypto_alloc_ahash(hash_algo_name[algo], 0, 0); > > > > In the case where algo isn't the same as ima_hash_algo, won't this > > replace the existing ima_ahash_tfm without freeing it? > > > > Look to next comment...
Yep, my mistake in reading the code.
Mimi
| |