lkml.org 
[lkml]   [2014]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] uml/net_kern: Eliminate NULL test after alloc_bootmem
    alloc_bootmem and related functions never return NULL. Thus a NULL
    test or memset after calls to these functions is unnecessary.

    The following Coccinelle semantic patch was used for making the change:

    @@
    expression E;
    statement S;
    @@

    E = \(alloc_bootmem\|alloc_bootmem_low\|alloc_bootmem_pages\|alloc_bootmem_low_pages\)(...)
    ... when != E
    - if (E == NULL) S

    Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
    Acked-by: Julia Lawall <julia.lawall@lip6.fr>
    ---
    arch/um/drivers/net_kern.c | 4 ----
    1 file changed, 4 deletions(-)

    diff --git a/arch/um/drivers/net_kern.c b/arch/um/drivers/net_kern.c
    index 7d26d9c..f70dd54 100644
    --- a/arch/um/drivers/net_kern.c
    +++ b/arch/um/drivers/net_kern.c
    @@ -659,10 +659,6 @@ static int __init eth_setup(char *str)
    }

    new = alloc_bootmem(sizeof(*new));
    - if (new == NULL) {
    - printk(KERN_ERR "eth_init : alloc_bootmem failed\n");
    - return 1;
    - }

    INIT_LIST_HEAD(&new->list);
    new->index = n;
    --
    1.9.1


    \
     
     \ /
      Last update: 2014-07-19 14:01    [W:3.946 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site