Messages in this thread | | | Date | Fri, 18 Jul 2014 22:36:07 -0400 | From | Sasha Levin <> | Subject | Re: [PATCH] usb-core: Remove Fix mes in file hcd.c |
| |
On 07/18/2014 01:34 PM, Nicholas Krause wrote: > I am removing two fix mes in this file as after dicussing then it seems > there is no reason to check against Null for usb_device as it can never > be NULL and this is check is therefore not needed. > > Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Please explain exactly why it's not needed, why it can never be NULL, and what prevents it from being NULL.
"after dicussing" (do you run spellcheck on your mails?) won't mean anything to someone looking at this commit in a year.
Your commit message also mentions usb_device which has nothing to do with your patch.
Thanks, Sasha
| |