lkml.org 
[lkml]   [2014]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] parisc: Remove FIXME comment
On 07/18/2014 10:37 PM, Nicholas Krause wrote:
> The comment for size of frame not being needed is incorrect , the
> function called needs this parameter.

Thanks for the patch Nicholas.

It has been queued up:
https://patchwork.kernel.org/patch/4587631/
and
https://patchwork.kernel.org/patch/4486231/

I will apply it at some point, but not yet.
There are other (more important) patches upcoming regarding the
signal handling, and I don't want to break those at the moment.

Helge

>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> arch/parisc/kernel/signal.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/parisc/kernel/signal.c b/arch/parisc/kernel/signal.c
> index 1cba8f2..1d550b5 100644
> --- a/arch/parisc/kernel/signal.c
> +++ b/arch/parisc/kernel/signal.c
> @@ -240,7 +240,6 @@ setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
> #endif
>
> usp = (regs->gr[30] & ~(0x01UL));
> - /*FIXME: frame_size parameter is unused, remove it. */
> frame = get_sigframe(ka, usp, sizeof(*frame));
>
> DBG(1,"SETUP_RT_FRAME: START\n");
>



\
 
 \ /
  Last update: 2014-07-19 00:21    [W:0.386 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site