lkml.org 
[lkml]   [2014]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [patch 13/13] mm: memcontrol: rewrite uncharge API
From
On Fri, Jul 18, 2014 at 4:45 PM, Johannes Weiner <hannes@cmpxchg.org> wrote:

> I assumed the source page would always be new, according to this part
> in fuse_try_move_page():
>
> /*
> * This is a new and locked page, it shouldn't be mapped or
> * have any special flags on it
> */
> if (WARN_ON(page_mapped(oldpage)))
> goto out_fallback_unlock;
> if (WARN_ON(page_has_private(oldpage)))
> goto out_fallback_unlock;
> if (WARN_ON(PageDirty(oldpage) || PageWriteback(oldpage)))
> goto out_fallback_unlock;
> if (WARN_ON(PageMlocked(oldpage)))
> goto out_fallback_unlock;
>
> However, it's in the page cache and I can't really convince myself
> that it's not also on the LRU. Miklos, I have trouble pinpointing
> where oldpage is instantiated exactly and what state it might be in -
> can it already be on the LRU?

oldpage comes from ->readpages() (*NOT* ->readpage()), i.e. readahead.

AFAICS it is added to the LRU in read_cache_pages(), so it looks like
it is definitely on the LRU at that point.

Thanks,
Miklos


\
 
 \ /
  Last update: 2014-07-18 18:21    [W:0.144 / U:0.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site