Messages in this thread | | | Date | Fri, 18 Jul 2014 08:39:34 -0500 | From | Alex Elder <> | Subject | Re: [PATCH v2 2/6] printk: LOG_CONT and LOG_NEWLINE are opposites |
| |
On 07/18/2014 05:53 AM, Petr Mládek wrote: >> @@ -1686,9 +1690,8 @@ asmlinkage int vprintk_emit(int facility, int level, >> > if (cont_add(facility, level, text, text_len)) >> > printed_len += text_len; >> > else >> > - printed_len += log_store(facility, level, >> > - lflags | LOG_CONT, 0, >> > - dict, dictlen, text, text_len); >> > + printed_len += log_store(facility, level, lflags, 0, >> > + NULL, 0, text, text_len); >> > } else { >> > bool stored = false; >> > > I do not see real benefit in this change. I think that it would cause > more confusion than help. I would suggest to remove it. Then I will > agree with this patch :-)
Done. I'm going to add your Reviewed-by based on this. Please correct me if that's not what you want.
-Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |