lkml.org 
[lkml]   [2014]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 010/170] iscsi-target: Explicily clear login response PDU in exception path
    Date
    From: Nicholas Bellinger <nab@linux-iscsi.org>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit 683497566d48f86e04d026de1ee658dd74fc1077 upstream.

    This patch adds a explicit memset to the login response PDU
    exception path in iscsit_tx_login_rsp().

    This addresses a regression bug introduced in commit baa4d64b
    where the initiator would end up not receiving the login
    response and associated status class + detail, before closing
    the login connection.

    Reported-by: Christophe Vu-Brugier <cvubrugier@yahoo.fr>
    Tested-by: Christophe Vu-Brugier <cvubrugier@yahoo.fr>
    Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    drivers/target/iscsi/iscsi_target_util.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/target/iscsi/iscsi_target_util.c b/drivers/target/iscsi/iscsi_target_util.c
    index 1039de499bc6..658c9c77ec04 100644
    --- a/drivers/target/iscsi/iscsi_target_util.c
    +++ b/drivers/target/iscsi/iscsi_target_util.c
    @@ -1294,6 +1294,8 @@ int iscsit_tx_login_rsp(struct iscsi_conn *conn, u8 status_class, u8 status_deta
    login->login_failed = 1;
    iscsit_collect_login_stats(conn, status_class, status_detail);

    + memset(&login->rsp[0], 0, ISCSI_HDR_LEN);
    +
    hdr = (struct iscsi_login_rsp *)&login->rsp[0];
    hdr->opcode = ISCSI_OP_LOGIN_RSP;
    hdr->status_class = status_class;
    --
    2.0.0


    \
     
     \ /
      Last update: 2014-07-18 16:21    [W:4.095 / U:0.328 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site