Messages in this thread | | | Date | Fri, 18 Jul 2014 00:29:37 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH] checkpatch.pl: Remove --file option |
| |
On 07/17/2014 08:34 AM, Richard Weinberger wrote: > checkpatch.pl is a nice tool to find issues in patches. > Sadly this tool gets more and more abused by various people to create > style cleanups for source files within the kernel. > In order to deal with that bad habit let's remove the --file option > and bring checkpatch.pl back to its original purpose. >
I have a number of problems with this patch.
First, 'abuse' is a relative term. It describes a use you (and possibly many others) may find objectionable, but that does not mean all uses are objectionable.
Second, just because something is abused doesn't mean it would be a good idea to take it away. Many of the amendmends to the US Constitution can be abused. Should freedom of speech be taken away because it can be abused ? I hope not. Many drugs can be abused. Should they be taken away ? I hope not. And so on.
Using your argument, you can take away anything that can be abused, which is pretty much everything. Not a good idea.
Guenter
| |