lkml.org 
[lkml]   [2014]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/3] fuse/dev: Fix unbalanced calls to kunmap_atomic() during splice I/O
From
On Mon, Jul 14, 2014 at 9:18 PM, Seth Forshee
<seth.forshee@canonical.com> wrote:
> fuse_copy_finish() assumes that mapaddr in fuse_copy_state refers
> to a valid mapping if currbuf is non-NULL, but this isn't always
> true when moving pages for splice I/O. This results in an
> unbalanced call to kunmap_atomic() and thus an unbalanced
> decrement of the preempt count. Avoid this by checking that
> mapaddr is non-NULL before calling kunmap_atomic().

I guess this is obsoleted by:

c55a01d360af fuse: avoid scheduling while atomic

which moves the kmap/kunmap closer to the actual use of the mapping.

Can you please verify?

Thanks,
Miklos


\
 
 \ /
  Last update: 2014-07-19 11:41    [W:0.171 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site