Messages in this thread | | | Date | Wed, 16 Jul 2014 11:27:40 +0300 | From | Peter De Schrijver <> | Subject | Re: [PATCH 2/6] clk: tegra: make tegra_clocks_apply_init_table arch_initcall |
| |
On Wed, Jul 16, 2014 at 09:19:33AM +0200, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Tue, Jul 15, 2014 at 06:24:32PM +0300, Peter De Schrijver wrote: > [...] > > diff --git a/drivers/clk/tegra/clk.c b/drivers/clk/tegra/clk.c > > index d081732..65cde4e 100644 > > --- a/drivers/clk/tegra/clk.c > > +++ b/drivers/clk/tegra/clk.c > > @@ -290,10 +290,13 @@ struct clk ** __init tegra_lookup_dt_id(int clk_id, > > > > tegra_clk_apply_init_table_func tegra_clk_apply_init_table; > > > > -void __init tegra_clocks_apply_init_table(void) > > +static int __init tegra_clocks_apply_init_table(void) > > { > > if (!tegra_clk_apply_init_table) > > - return; > > + return 0; > > Shouldn't this be an error? Or perhaps WARN()? To make sure this gets
An arch_initcall will be called for every ARM platform I think? In case this gets called on a non-Tegra platform, tegra_clk_apply_init_table will not be set and therefore a silent return 0; seems the most appropriate thing to do to me?
Cheers,
Peter.
| |