Messages in this thread | | | Date | Wed, 16 Jul 2014 23:57:40 -0400 | From | Johannes Weiner <> | Subject | Re: [patch] mm, writeback: prevent race when calculating dirty limits |
| |
On Wed, Jul 16, 2014 at 05:36:49PM -0700, David Rientjes wrote: > Setting vm_dirty_bytes and dirty_background_bytes is not protected by any > serialization. > > Therefore, it's possible for either variable to change value after the > test in global_dirty_limits() to determine whether available_memory needs > to be initialized or not. > > Always ensure that available_memory is properly initialized. > > Cc: stable@vger.kernel.org > Signed-off-by: David Rientjes <rientjes@google.com>
Any such race should be barely noticable to the user, so I assume you realized this while looking at the code? The patch looks good, but I don't see that it's stable material.
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
| |