Messages in this thread Patch in this message | | | From | Adrian Hunter <> | Subject | [PATCH V2 2/2] perf tools: Fix leak of 'struct thread' on error path | Date | Wed, 16 Jul 2014 10:19:44 +0300 |
| |
__machine__findnew_thread() creates a 'struct thread' but does not free it on the error path.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> --- tools/perf/util/machine.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index 5b80877..b75af25 100644 --- a/tools/perf/util/machine.c +++ b/tools/perf/util/machine.c @@ -325,8 +325,10 @@ static struct thread *__machine__findnew_thread(struct machine *machine, * within thread__init_map_groups to find the thread * leader and that would screwed the rb tree. */ - if (thread__init_map_groups(th, machine)) + if (thread__init_map_groups(th, machine)) { + thread__delete(th); return NULL; + } } return th; -- 1.8.3.2
| |