Messages in this thread | | | Date | Wed, 16 Jul 2014 10:20:21 -0700 | From | Zach Brown <> | Subject | Re: [PATCH 1/1] Btrfs: fix sparse warning |
| |
On Tue, Jul 15, 2014 at 09:17:17PM +0200, Fabian Frederick wrote: > Fix the following sparse warning: > fs/btrfs/send.c:518:51: warning: incorrect type in argument 2 (different address spaces) > fs/btrfs/send.c:518:51: expected char const [noderef] <asn:1>*<noident> > fs/btrfs/send.c:518:51: got char * > > We can safely use (const char __user *) with set_fs(KERNEL_DS)
Yeah, that cast is correct.
Reviewed-by: Zach Brown <zab@zabbo.net>
> @@ -515,7 +515,8 @@ static int write_buf(struct file *filp, const void *buf, u32 len, loff_t *off)
Though this probably wants to be rewritten in terms of kernel_write(). That'd give an opportunity to get rid of the sctx->send_off and have it use f_pos in the filp.
- z
| |