| From | David Laight <> | Subject | RE: [PATCH RFCv3 08/14] arm64: introduce aarch64_insn_gen_movewide() | Date | Wed, 16 Jul 2014 16:25:35 +0000 |
| |
From: Will Deacon ... > > + BUG_ON(imm < 0 || imm > 65535); > > Do this check with masking instead?
The compiler will convert that to a single unsigned comparison.
... > > + BUG_ON(shift != 0 && shift != 16 && shift != 32 && > > + shift != 48);
OTOH I don't think it will convert that to: BUG_ON(shift & ~48);
David
|