Messages in this thread | | | Subject | Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected | From | "Ivan T. Ivanov" <> | Date | Wed, 16 Jul 2014 17:00:54 +0300 |
| |
On Wed, 2014-07-16 at 14:53 +0100, Mark Brown wrote: > On Wed, Jul 16, 2014 at 06:26:15PM +0530, Pramod Gurav wrote: > > Fix your mailer to word wrap within paragraphs, this will make your > mails more legible - see Documentation/email-clients.txt. > > > On Wednesday, 16 July, 2014 5:55pm, "Stanimir Varbanov" <svarbanov@mm-sol.com> said: > > > The CONFIG_SPMI option is visible in menuconfig hence either it should > > be set by default in multi_v7_defconfig(like in qcom_defconfig) or > > driver owner should mention a 'depneds on CONFIG_SPMI' as suggested by > > Lars-Peter Clausen. > > > I prefer the former (defconfig). > > No, this isn't an either/or thing - the dependency is absolutely > mandatory if the device needs SPMI. The defconfigs are a separate > thing, they just exist to give people a starting point for configuring > their kernel so if the device using SPMI is important for relevant > systems the defconfig needs to be set up to enable it but that's > separate to the dependency since there's no need for people to ever even > look at defconfigs.
Then config REGMAP_SPMI should depend on SPMI, right?
Regards, Ivan
| |