lkml.org 
[lkml]   [2014]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] driver/tty: Fix a warning in check_tty_count
Hi Jiri,
You are right, I tested the latest kernel, did not see this bug.
So I will only submit this patch to Redhat.

Thanks
Zhenhua

On 07/15/2014 05:16 PM, Jiri Slaby wrote:
> Hi,
>
> On 07/15/2014 11:08 AM, Li, ZhenHua wrote:
>> This bug was founded in RHEL 6, kernel version 2.6.32.
>>
>> But I also checked the file tty_io.c in latest kernel, not all the code
>> protected by tty_lock(tty).
>>
>> For example, in function tty_del_file,
>>
>> if (--tty->count < 0) {
>> }
>> and
>> tty_del_file(filp);
>> are not surrounded by tty_lock(tty).
> Sure, but there is tty_lock_pair instead.
>
>> So I think the new lock is necessary.
> Nope, sorry, you have to complain to RedHat about this kernel. Unless
> you can reproduce this with the vanilla kernel.
>
> thanks,



\
 
 \ /
  Last update: 2014-07-16 13:21    [W:0.045 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site